db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4430) Make ij's SHOW and DESCRIBE commands more db agnostic
Date Sat, 14 Nov 2009 18:14:39 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777980#action_12777980
] 

Knut Anders Hatlen commented on DERBY-4430:
-------------------------------------------

Thanks, Sylvain! The patch looks good to me. I'll run the tests and commit it if I don't see
any failures. I've made one change to the patch, re-introducing the comment that was removed
from the original identifier() method.

The failure you're seeing in bootLock is probably not related to the patch. I found a bug
report, DERBY-4179, which described the same failure. It was closed because it only happened
once, but I've reopened it and pointed it to this issue.

> Make ij's SHOW and DESCRIBE commands more db agnostic
> -----------------------------------------------------
>
>                 Key: DERBY-4430
>                 URL: https://issues.apache.org/jira/browse/DERBY-4430
>             Project: Derby
>          Issue Type: Improvement
>          Components: Tools
>    Affects Versions: 10.6.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Sylvain Leroux
>            Priority: Minor
>         Attachments: DERBY-4430.ij.out, DERBY-4430.patch, DERBY-4430.sql
>
>
> ij's SHOW and DESCRIBE commands use DatabaseMetaData in order to be portable to other
databases than Derby, and in many cases they work fine with other databases. However, the
variants of the commands that take a table name or a schema name assume that unquoted identifiers
are converted to and stored in upper case internally. This is not true for all databases,
and since these commands don't accept quoted identifiers, there's currently no way to access
tables/schemas that are not all upper case.
> One possible fix is to make the identifier() method in ij.jj use the DatabaseMetaData
methods storesLowerCaseIdentifiers(), storesMixedCaseIdentifiers() and storesUpperCaseIdentifiers()
to decide whether it should convert the identifier to lower case, keep it unchanged, or convert
it to upper case. Currently, that method always converts the identifiers to upper case.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message