Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <308204687.1255604431487.JavaMail.jira@brutus>
Date: Thu, 15 Oct 2009 04:00:31 -0700 (PDT)
From: "Knut Anders Hatlen (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-4394) Add documentation for ROLLUP
 functionality in GROUP BY clause
In-Reply-To: <1825899815.1254439283622.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DERBY-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766008#action_12766008 ] 

Knut Anders Hatlen commented on DERBY-4394:
-------------------------------------------

In the syntax description, it looks like some square brackets have been misplaced so that the entire list of column names has been made optional. Using { and } for grouping may also make the syntax easier to read. I suggest something like this:

GROUP BY
  { column-Name [ , column-Name ]* } |
  { ROLLUP ( column-Name [ , column-Name ]* ) }

The sentence starting with "Using the ROLLUP syntax" lacks a full stop. Perhaps it's better to say "ROLLUP keyword" instead of "ROLLUP syntax" too?

The existing examples use upper case SQL statements. For consistency, we may want to use upper case in the new example too.

> Add documentation for ROLLUP functionality in GROUP BY clause
> -------------------------------------------------------------
>
>                 Key: DERBY-4394
>                 URL: https://issues.apache.org/jira/browse/DERBY-4394
>             Project: Derby
>          Issue Type: Sub-task
>            Reporter: Bryan Pendleton
>            Assignee: Bryan Pendleton
>         Attachments: addSyntaxAndExample.diff, fixIntentationOfExample.diff, rrefsqlj32654.html, rrefsqlj32654.html
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.