db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4409) Make some tests run faster by using CleanDatabaseSetup + decorateSQL + rollback idiom
Date Thu, 15 Oct 2009 07:33:31 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765948#action_12765948
] 

Knut Anders Hatlen commented on DERBY-4409:
-------------------------------------------

+1. Looks like an improvement to me.

The calls to rollback() in the test cases are not actually needed, because (a) auto-commit
is enabled, (b) BaseJDBCTestCase.tearDown() already calls rollback(), and (c) all the tests
are read-only.

(The test originally had auto-commit disabled because setUp() called setAutoCommit(false).
Calling setAutoCommit(false) from the decorator does not have the same effect because it uses
a different Connection instance. This is just an observation, and I'm not suggesting that
we should disable auto-commit again.)

> Make some tests run faster by using  CleanDatabaseSetup + decorateSQL + rollback idiom
> --------------------------------------------------------------------------------------
>
>                 Key: DERBY-4409
>                 URL: https://issues.apache.org/jira/browse/DERBY-4409
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Dag H. Wanvik
>            Priority: Minor
>         Attachments: OrderByAndSortAvoidance-faster.diff, OrderByAndSortAvoidance-faster.stat
>
>
> For example, for OrderByAndSortAvoidance, this reduces running time on my box from ca
5 minutes to ca 1 minute, cf
> patch OrderByAndSortAvoidance-faster.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message