db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-4355) Implement CROSS JOIN
Date Wed, 09 Sep 2009 20:24:57 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Knut Anders Hatlen updated DERBY-4355:

    Attachment: cross_v3.diff

Here's an updated patch (v3) which addresses the issues mentioned in the previous comments.

Changes from the previous revision of the patch:

* The right side of a cross join is now a <table factor> and not a <table reference>.
The current grammar doesn't separate between <table reference> and <table factor>,
so the patch splits out some of the code from the current <table reference> rule into
a new <table factor> rule. This split also made some duplicated code go away, so the
patch actually removes more code from the parser than it adds.

* Added test cases for the queries the previous patch didn't handle correctly.

* Removed a test case from lang/db2Compatibility.sql which verified that a simple cross join
failed with syntax error.

All the regression tests ran cleanly. The patch is ready for review.

> Implement CROSS JOIN
> --------------------
>                 Key: DERBY-4355
>                 URL: https://issues.apache.org/jira/browse/DERBY-4355
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>         Environment: any
>            Reporter: Bernt M. Johnsen
>            Assignee: Knut Anders Hatlen
>         Attachments: cross.diff, cross_v2.diff, cross_v3.diff
> Implement the CROSS JOIN syntax
> SELECT * from t1 CROSS JOIN t2;
> as an alternative syntax to
> SELECT * FROM t1, t2; 
> This should be pretty straight forward and ease the migration of SQL code to Derby.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message