db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-3002) Add support for GROUP BY ROLLUP
Date Fri, 18 Sep 2009 00:25:57 GMT

     [ https://issues.apache.org/jira/browse/DERBY-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Bryan Pendleton updated DERBY-3002:
-----------------------------------

    Attachment: useAggregateObserver.diff

Attached 'useAggregateObserver.diff' has one major change from the
previous patch proposal: it restores the use of the AggregateSortObserver
for the following common and important special case:
 - the input data is not already in sorted order
 - the GROUP BY does not use ROLLUP
 - the GROUP BY does not use distinct aggregates

The patch is also up to date with current trunk, and resolves some merge conflicts.

This revised patch passes all the regression tests, including the new ROLLUP tests.

More importantly, this revised patch matches the current trunk in performance
on the DERBY-4363 benchmark of GROUP BY performance.

I still have to investigate the other issues raised during the previous round of code
review, but this patch seemed to be at a state worth posting so here it is.


> Add support for GROUP BY ROLLUP
> -------------------------------
>
>                 Key: DERBY-3002
>                 URL: https://issues.apache.org/jira/browse/DERBY-3002
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.4.1.3
>            Reporter: Bryan Pendleton
>            Assignee: Bryan Pendleton
>            Priority: Minor
>         Attachments: fixWhiteSpace.diff, IncludesASimpleTest.diff, passesRegressionTests.diff,
prototypeChangeNoTests.diff, rewriteGroupByRS.diff, rollupNullability.diff, UpdateToTrunkSep2009.diff,
useAggregateObserver.diff, useLookahead.diff
>
>
> Provide an implementation of the ROLLUP form of multi-dimensional grouping according
to the SQL standard.
> See http://wiki.apache.org/db-derby/OLAPRollupLists for some more detailed information
about this aspect of the SQL standard.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message