db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Leroux (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (DERBY-3809) Add a SHOW FUNCTONS command to ij
Date Mon, 28 Sep 2009 13:16:16 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760231#action_12760231
] 

Sylvain Leroux edited comment on DERBY-3809 at 9/28/09 6:16 AM:
----------------------------------------------------------------

Here is a new version of the patch.

As you suggested, I used Java reflection to call the getFunctions method. As a side effect,
I no longer need to escape the schema name.

Concerning unit tests, I'm not quite sure of myself: I add some lines to ij7.sql and ij7.out.
It appears to do the job, but I don't know if this is enough.
On that matter, after I have changed the help message in toolsmessages.properties, I noticed
all tests in org.apache.derbyTesting.functionTests.tests.tools._Suite still pass. Even before
updating ij.out (whose last test check this help message) ???

Finally, note that I use wider columns for the result set than showProcedures. I think those
are are far too narrow, especially for the "REMARKS" column. As you will notice in the following
example, the Java class name are truncated. So the result is not that useful.
ij> SHOW PROCEDURES IN SQLJ;
PROCEDURE_SCHEM     |PROCEDURE_NAME                |REMARKS             
------------------------------------------------------------------------
SQLJ                |INSTALL_JAR                   |org.apache.derby.ca&
SQLJ                |REMOVE_JAR                    |org.apache.derby.ca&
SQLJ                |REPLACE_JAR                   |org.apache.derby.ca&

On the other hand, from the user point of view, I think that both showProcedures and showFunctions
should produce a similar display. So I should normalize that one side or the other...

Sylvain.

      was (Author: sleroux):
    Here is a new version of the patch.

As you suggested, I used Java reflection to call the getFunctions method. As a side effect,
I no longer need to escape the schema name.

Concerning unit tests, I'm not quite sure of myself: I add some lines to ij7.sql and ij7.out.
It appears to do the job, but I don't know if this is enough.
On that matter, after I have changed the help message in toolsmessages.properties, I noticed
all tests in org.apache.derbyTesting.functionTests.tests.tools._Suite still pass. Even before
updating ij.out (whose last test check this help message) ???

Finally, note that I use wider columns for the result set than showProcedures. I think those
are are far too narrow, especially for the "REMARK" column. As you will notice in the following
example, the Java class name are truncated.  So the result is not that useful.
ij> SHOW PROCEDURES IN SQLJ;
PROCEDURE_SCHEM     |PROCEDURE_NAME                |REMARKS             
------------------------------------------------------------------------
SQLJ                |INSTALL_JAR                   |org.apache.derby.ca&
SQLJ                |REMOVE_JAR                    |org.apache.derby.ca&
SQLJ                |REPLACE_JAR                   |org.apache.derby.ca&

On the other hand, from the user point of view, I think that both showProcedures and showFunctions
should produce a similar display. So I should normalize that one side or the other...

Sylvain.
  
> Add a SHOW FUNCTONS command to ij
> ---------------------------------
>
>                 Key: DERBY-3809
>                 URL: https://issues.apache.org/jira/browse/DERBY-3809
>             Project: Derby
>          Issue Type: Improvement
>          Components: Tools
>    Affects Versions: 10.4.1.3
>            Reporter: Rick Hillegas
>            Assignee: Sylvain Leroux
>         Attachments: show-functions-2.diff, show-functions.diff
>
>
> Currently, the ij SHOW command can give you information on a number of schema objects,
including procedures. It should be fairly easy to add SHOW FUNCTIONS as well. This request
surfaced on the user list: http://www.nabble.com/How-can-i-see-my-self-defined-functions--td18773980.html#a18773980

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message