Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <1498979228.1250109915016.JavaMail.jira@brutus>
Date: Wed, 12 Aug 2009 13:45:15 -0700 (PDT)
From: "Tiago R. Espinha (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-3801) Convert
 "org.apache.derbyTesting.functionTests.tests.lang.holdCursorIJ.sql" to
 junit.
In-Reply-To: <1414263751.1217236172567.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DERBY-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742567#action_12742567 ] 

Tiago R. Espinha commented on DERBY-3801:
-----------------------------------------

Myrna,

I have been working on this test conversion basing my work on Junjie's patch and have only now noticed that you had added useful comments to this issue. 

On this last comment of yours, you said:
"...you should be able to identify which test cases (fixtures) in what you've converted now are suitable for adding to the existing HoldCursorTest..."

Looking at the HoldCursorTest though, I can see that all of the cases where a dual behavior is required (for embedded and client/server) are actually already covered. There's only just one case that does not seem to be covered, but I think this is actually only useful for testing the ij syntax. The case is when we are trying the 'WITH CS' clause as follows:
get with nohold cursor jdk1 as 'SELECT * FROM t1 WITH CS';

So, to bottom-line this, I'm thinking of removing these fixtures from this HoldCursorIJTest (since they already exist in HoldCursorTest), extend it from ScriptTestCase and build on from that. I have never done one of these tests before but I should be able to get hints from other already existing tests with the same characteristics.

> Convert "org.apache.derbyTesting.functionTests.tests.lang.holdCursorIJ.sql" to junit. 
> --------------------------------------------------------------------------------------
>
>                 Key: DERBY-3801
>                 URL: https://issues.apache.org/jira/browse/DERBY-3801
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Junjie Peng
>            Assignee: Tiago R. Espinha
>         Attachments: derby-3801-1-patch.txt, derby-3801-2.patch, derby-3801-2.stat
>
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.holdCursorIJ.sql" to junit. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.