db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-4087) Clean up debug printing of the abstract syntax trees after parsing, binding and optimization
Date Sat, 08 Aug 2009 20:28:14 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Dag H. Wanvik updated DERBY-4087:
---------------------------------

    Attachment: derby-4087-a.stat
                derby-4087-a.diff

Uploading a patch that addresses these issues, derby-4087-a.  I have tried to ensure correctness
by
making lots of manual queries and inspecting the dumped trees for readability.
To me the trees look more consistent and readable with the patch, but there are many changes
so its quite possible
I made some errors in the process. If people think it's OK, further tweaks can be done later
now that we have a
more consistent use of the patterns.
Since this all concerns code used used for debugging, there are presently no tests.
The regressions ran OK at least (hardly surprising) ;-)


> Clean up debug printing of the abstract syntax trees after parsing, binding and optimization

> ---------------------------------------------------------------------------------------------
>
>                 Key: DERBY-4087
>                 URL: https://issues.apache.org/jira/browse/DERBY-4087
>             Project: Derby
>          Issue Type: Improvement
>          Components: Miscellaneous, SQL
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>            Priority: Trivial
>         Attachments: derby-4087-a.diff, derby-4087-a.stat
>
>
> Currently, the printing is often inconsistent:
> - some subtrees not printed
> - wrong indentation due to missing newlines, or lacking level increments
> - redundant printing of subtrees (AST is really a DAG, would be nice to print only once
and then refer back to show aliasing)
> - some items printed twice due to inconsistent usage of pattern

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message