db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (DERBY-4087) Clean up debug printing of the abstract syntax trees after parsing, binding and optimization
Date Sun, 30 Aug 2009 00:04:32 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749211#action_12749211
] 

Dag H. Wanvik edited comment on DERBY-4087 at 8/29/09 5:03 PM:
---------------------------------------------------------------

Uploading aother patch for this issue, which re-introduces the changes that had to be rolled
back.
derby-4087-statistics fixes the formatting errors seen by Knut and Bryan. Since I could not
use java.util.regexp, I hand-coded three patterns in StringUtil.java this time around.
The reason for all this text massaging is that the qualifiers are pre-formatted before the
output indentation level is knows, which lead to the weird formatting seen. The new method
StringUtil.ensureIndent fixes that problem.

I had to modify many old harness test masters, but now they all look nicer at least :)

Regressions passed ok.

      was (Author: dagw):
    Uploading aother patch for this issue, which re-introduces the changes that had to be
rolled back.
derby-4087-statistics fixes the formatting errors seen by Knut and Bryan. Since I could not
use java.util.regexp, I hand-coded three patterns in StringUtil.java this time around.
The reason for all this text massaging is that the qualifiers are pre-formatted before the
output indentation level is knows, which leads to the weird formatting seen. The new method
StringUtil.ensureIndent fixes that problem.

  
> Clean up debug printing of the abstract syntax trees after parsing, binding and optimization

> ---------------------------------------------------------------------------------------------
>
>                 Key: DERBY-4087
>                 URL: https://issues.apache.org/jira/browse/DERBY-4087
>             Project: Derby
>          Issue Type: Improvement
>          Components: Miscellaneous, SQL
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>            Priority: Trivial
>         Attachments: derby-4087-a.diff, derby-4087-a.stat, derby-4087-b.diff, derby-4087-b.stat,
derby-4087-statistics.diff, derby-4087-statistics.stat, dumpquery, sample.log
>
>
> Currently, the printing is often inconsistent:
> - some subtrees not printed
> - wrong indentation due to missing newlines, or lacking level increments
> - redundant printing of subtrees (AST is really a DAG, would be nice to print only once
and then refer back to show aliasing)
> - some items printed twice due to inconsistent usage of pattern

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message