db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4318) convert inbetween.sql to JUNIT
Date Thu, 06 Aug 2009 17:24:14 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740157#action_12740157

Bryan Pendleton commented on DERBY-4318:

With the statementCacheSize set to 0, we get a cleaner run, but we still find
16 dependencies when the IJ-based test finds only 2.

I looked into the dependencies in more detail, and there are 2 in-memory
dependencies found, and 14 stored dependencies.

The stored dependencies have to do with StoredPreparedStatement instances
for the various system catalogs (SYSALIASES, SYSSCHEMAS, etc.)

The in-memory dependencies are for the call to CONSISTENCYCHECKER itself,
and for a separate call to SYSCS_SET_RUNTIMESTATISTICS which occurs
later in the test.

I wonder if the IJ test harness ran this test in such a way that there were
no stored dependencies printed, but when we run it as a JUnit test we
get the stored dependencies.

I'm not actually sure what this test is trying to achieve by running the  ConsistencyChecker.

Here's two possible ideas:
1) Change the test so that the expected output includes the actual number of
dependencies we find, even though that's a different number than we got
with the old IJ-based test. (we get 16 depedencies the first time, 18 the second time)
2) Change the test to just check the number of open scans, and not count the
number of dependencies at all.

Does anybody else (Rick?) know why this test was calling the ConsistencyChecker
and whether the number of dependencies that we found is important or not?

> convert inbetween.sql to JUNIT
> ------------------------------
>                 Key: DERBY-4318
>                 URL: https://issues.apache.org/jira/browse/DERBY-4318
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>         Attachments: inbetween.junit, InbetweenTest.diff, InbetweenTest.diff, InbetweenTest.diff,
> conversion of inbetween.sql to JUNIT

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message