db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4304) Network Server shutdown should handle exceptions and finish the server shutdown completely
Date Wed, 12 Aug 2009 13:55:14 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742356#action_12742356
] 

Kathey Marsden commented on DERBY-4304:
---------------------------------------

Hi Mamta,

I took a quick look at the diff and noticed that the normal timestamps that print  for network
server commands are commented out, which I guess you did for your testing.  These should be
enabled again before commit.

The rest of the diff I think is  ok but was a little hard to read because of the indentation
change.    Thanks for doing this. I think this will finally allow us to get full reporting
of any shutdown issues.  It would be great to see this change backported, but you would need
to be careful to also backport the fixes for the bugs found when fixing this issue as well.

Kathey

> Network Server shutdown should handle exceptions and finish the server shutdown completely
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-4304
>                 URL: https://issues.apache.org/jira/browse/DERBY-4304
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server
>    Affects Versions: 10.6.0.0
>            Reporter: Mamta A. Satoor
>            Assignee: Mamta A. Satoor
>         Attachments: DERBY4304_fixNPE_patch2_diff.txt, DERBY4304_handleExceptions_patch1_diff.txt,
DERBY4304ShutdownException_patch3_diff.txt, logAfterPatch3Changes.txt, logBeforePatch3Changes.txt
>
>
> While working on DERBY-4053, found that an exception from Connection.close was not handled
properly by the server shutdown code which caused a new instance server startup to hang. Resolved
the problem with Connection close but in general, we should
> 1) Make sure an exception during shutdown processing does not prevent the remaining shutdown
tasks, like closing the server socket from occurring. 
> 2) Make sure any exceptions that occur in shutdown processing are reported to the console.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message