db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4347) Provide a property to increase network server start timeout for JUnit tests
Date Tue, 18 Aug 2009 06:38:14 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744386#action_12744386
] 

Knut Anders Hatlen commented on DERBY-4347:
-------------------------------------------

We could also just increase the default wait time. It shouldn't have any negative effects
except that it takes longer for the test to fail if the server doesn't start, but that's hardly
worth optimizing for.

Minor nit: If we add the system property, I think it would be better to specify the number
of seconds to wait instead of milliseconds, as I don't see the need for ms resolution. It
would also be more in line with the other (non-testing) timeout properties like derby.locks.*timeout.

> Provide a property to increase network server start  timeout  for JUnit tests
> -----------------------------------------------------------------------------
>
>                 Key: DERBY-4347
>                 URL: https://issues.apache.org/jira/browse/DERBY-4347
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.5.3.0, 10.6.0.0
>            Reporter: Kathey Marsden
>            Priority: Minor
>
>  Sometimes when running JUnit tests with jvm options that are known to slow things down
significantly network server start timeouts can occur e.g.
> SecureServerTest( Opened = false, Authenticated= false, CustomDerbyProperties= null,
WildCardHost= null )junit.framework.AssertionFailedError: Timed out waiting for network server
to start:Spawned SpawnedNetworkServer exitCode=143
> 		 at org.apache.derbyTesting.junit.NetworkServerTestSetup.setUp(NetworkServerTestSetup.java:203)
> 		 at junit.extensions.TestSetup$1.protect(TestSetup.java:18)
> 		 at junit.extensions.TestSetup.run(TestSetup.java:23)
> 		 at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
> 		 at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
> 		 at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
> 		 at junit.extensions.TestSetup.run(TestSetup.java:23)
> 		 at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
> 		 at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
> 		 at junit.extensions.TestSetup.run(TestSetup.java:23)
> 		 at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
> 		 at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
> 		 at junit.extensions.TestSetup.run(TestSetup.java:23)
> The current wait time is 40 seconds and is set in org.apache.derbyTesting.junit.NetworkServerTestSetup
>  
> /** Setting maximum wait time to 40 seconds.   On some platforms
>      * it may take this long to start the server.  Increasing the wait
>      *  time should not adversely affect those
>      *  systems with fast port turnaround as the actual code loops for 
>      *  SLEEP_TIME intervals, so should never see WAIT_TIME.
>      */
>     private static final long WAIT_TIME = 40000;
>     
> It would be nice to have system property (maybe derby.tests.networkServerStartTimeout=<ms>)
 to allow this to be configurable in environments where we expect the start to take longer.
> I am not sure if there are other timeouts in the tests for replication etc or if they
all use this same setting.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message