db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mamta A. Satoor (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-4304) Network Server shutdown should handle exceptions and finish the server shutdown completely
Date Wed, 12 Aug 2009 00:40:14 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mamta A. Satoor updated DERBY-4304:
-----------------------------------

    Attachment: DERBY4304ShutdownException_patch3_diff.txt
                logBeforePatch3Changes.txt
                logAfterPatch3Changes.txt

Attaching a new patch DERBY4304ShutdownException_patch3_diff.txt which puts a new try catch
block around all of the server shutdown code in case if there is some exception being thrown
which is not getting caught. The catch block will log into the log file but if that fails
for some reason, it will also just dump the stack trace using ex.printStackTrace().

I have attached for reference the server console log with my changes logAfterPatch3Changes.txt
and without my changes logBeforePatch3Changes.txt. i do not see any new exception in the log
file when running junit suite. I will also run derbyall. If no one has any feedback to this
patch, I will go ahead and commit it tomorrow.

> Network Server shutdown should handle exceptions and finish the server shutdown completely
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-4304
>                 URL: https://issues.apache.org/jira/browse/DERBY-4304
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server
>    Affects Versions: 10.6.0.0
>            Reporter: Mamta A. Satoor
>            Assignee: Mamta A. Satoor
>         Attachments: DERBY4304_fixNPE_patch2_diff.txt, DERBY4304_handleExceptions_patch1_diff.txt,
DERBY4304ShutdownException_patch3_diff.txt, logAfterPatch3Changes.txt, logBeforePatch3Changes.txt
>
>
> While working on DERBY-4053, found that an exception from Connection.close was not handled
properly by the server shutdown code which caused a new instance server startup to hang. Resolved
the problem with Connection close but in general, we should
> 1) Make sure an exception during shutdown processing does not prevent the remaining shutdown
tasks, like closing the server socket from occurring. 
> 2) Make sure any exceptions that occur in shutdown processing are reported to the console.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message