db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4338) Network client raises error "executeQuery method can not be used for update" when sql is preceded by /* */ comments
Date Tue, 25 Aug 2009 13:35:59 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747404#action_12747404

Knut Anders Hatlen commented on DERBY-4338:

This looks like an improvement to me. Two small comments:

1) Should getNonCommentToken() also skip '{' when in the OUTSIDE state? I was thinking of
JDBC escaped call statements, like "{ call TOURS.BOOK_TOUR(?, ?) }", where the first token
should be "CALL" and not "{".

2) CommentTest.suite() could be simplified to "return TestConfiguration.defaultSuite(CommentTest.class);"

> Network client raises error "executeQuery method can not be used for update" when sql
is preceded by /* */ comments
> -------------------------------------------------------------------------------------------------------------------
>                 Key: DERBY-4338
>                 URL: https://issues.apache.org/jira/browse/DERBY-4338
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client
>    Affects Versions:,,,
>            Reporter: Will Gomes
>            Assignee: Dag H. Wanvik
>         Attachments: derby-4338-a.diff, derby-4338-a.stat
> Network derby client does not properly detect a sql select statement preceded by /* */
comments.  As a result the sql appears to be detected as an update statement, and results
in  the following error:
>  org.apache.derby.client.am.SqlException: executeQuery method can not be used for update.
> 	at org.apache.derby.client.am.Statement.checkForAppropriateSqlMode(Unknown Source)
> 	at org.apache.derby.client.am.PreparedStatement.flowExecute(Unknown Source)
> 	at org.apache.derby.client.am.PreparedStatement.executeQueryX(Unknown Source)
> The problem appears to be in Statment.parseSqlAndSetSqlModes(), which only appears to
check for "--" style comments.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message