Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 33500 invoked from network); 29 Jul 2009 21:02:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 29 Jul 2009 21:02:38 -0000 Received: (qmail 35093 invoked by uid 500); 29 Jul 2009 21:02:39 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 35054 invoked by uid 500); 29 Jul 2009 21:02:39 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 35022 invoked by uid 99); 29 Jul 2009 21:02:39 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jul 2009 21:02:39 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jul 2009 21:02:35 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id D83D3234C052 for ; Wed, 29 Jul 2009 14:02:14 -0700 (PDT) Message-ID: <1265770898.1248901334884.JavaMail.jira@brutus> Date: Wed, 29 Jul 2009 14:02:14 -0700 (PDT) From: "Mamta A. Satoor (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Commented: (DERBY-4317) convert columnDefaults.sql to JUNIT In-Reply-To: <1527023931.1248107235079.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736829#action_12736829 ] Mamta A. Satoor commented on DERBY-4317: ---------------------------------------- Eranda, I just finished reviewing the test conversion and it looks good. After reviewing the test, I think there are quite a few create tables that you probably just need to keep in your test fixtures since we are testing default at create table time for some of those tests. There may be handful of other table creation which can be moved into decorateSQL since they test defaults at insert/update time. I will leave it to your judgement call if you want to leave all the table creations in their test fixtures for clarity purpose since we are mainly testing for defaults at create and right after create table times. > convert columnDefaults.sql to JUNIT > ----------------------------------- > > Key: DERBY-4317 > URL: https://issues.apache.org/jira/browse/DERBY-4317 > Project: Derby > Issue Type: Improvement > Components: Test > Reporter: Eranda Sooriyabandara > Assignee: Eranda Sooriyabandara > Priority: Minor > Attachments: ColumnDefaultsTest.diff, ColumnDefaultsTest.diff > > > Conversion of the columnDefaults.sql to JUNIT -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.