Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 25644 invoked from network); 20 Jul 2009 14:10:34 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 20 Jul 2009 14:10:34 -0000 Received: (qmail 13365 invoked by uid 500); 20 Jul 2009 14:11:39 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 13319 invoked by uid 500); 20 Jul 2009 14:11:39 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 13311 invoked by uid 99); 20 Jul 2009 14:11:39 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Jul 2009 14:11:39 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Jul 2009 14:11:36 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 432A5234C044 for ; Mon, 20 Jul 2009 07:11:15 -0700 (PDT) Message-ID: <1019768074.1248099075260.JavaMail.jira@brutus> Date: Mon, 20 Jul 2009 07:11:15 -0700 (PDT) From: "Kristian Waagan (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Updated: (DERBY-4293) Mutable public static variables In-Reply-To: <173705591.1246146767427.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-4293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-4293: ----------------------------------- Issue & fix info: (was: [Patch Available]) The state of this issue isn't quite clear to me, but I cleared the patch available flag as both patches have been committed. > Mutable public static variables > ------------------------------- > > Key: DERBY-4293 > URL: https://issues.apache.org/jira/browse/DERBY-4293 > Project: Derby > Issue Type: Improvement > Components: Build tools, Network Client, SQL, Store > Affects Versions: 10.6.0.0 > Reporter: Sebb > Attachments: derbyfinal.patch, derbyfinal2.patch > > > There are quite a few instances of public static fields which appear to be intended to be constant, but which are not final. > The code would be safer if all the constant fields were made final. > Patch to follow for some of the problem fields. > The following also ought to be fixed: > org.apache.derby.iapi.services.property.PropertyUtil.servicePropertyList (e.g. use an accessor to lookup the values) > org.apache.derby.iapi.types.JSQLType.primitiveNames (ditto) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.