db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-4031) If NO_GENERATED_KEYS is specified, Statement.getGeneratedKeys should return an empty ResultSet, not null
Date Fri, 03 Jul 2009 11:35:47 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Knut Anders Hatlen updated DERBY-4031:
--------------------------------------

    Description: 
Currently Derby returns null from Statement.getGeneratedKeys() if  the statement is prepared
or executed with Statement.NO_GENERATED_KEYS. The javadoc says:

If this Statement object did not generate any keys, an empty ResultSet object is returned.

so we should return an empty ResultSet for this case.  It is not entirely clear what the structure
of the ResultSet and ResultSetMetaData should be.  I tend to think the following:

getConcurrency() - inherit from the parent statement
getStatement() - null

ResultSetMetaData
getColumnCount - 0


an alternative would be to have the ResultSetMetaData match the signature of Identity_Val_local()
but I think to return 0 columns makes more sense.

  was:
Currently Derby returns null from Statement.getGeneratedKeys() if  the statement is prepared
or executed with Statement.NO_GENERATED_KEYS. The javadoc says:

If this Statement object did not generate any keys, an empty ResultSet object is returned.

so we should return an empty ResultSet for this case.  It is not entirely clear what the structure
of the ResultSet and ResultSetMetaData should be.  I tend to think the following:

getConcurrency() - inherit from the parent statement
getStatement() - null

ResultSetMetaData
getColumnCount - 0


an alternative would be to have the ResultSetMetaData match the signature of Identity_Val_local()
but I think to return 0 columns makes more sense.





































(Removed lots of trailing blank lines from the description for readability.)

> If NO_GENERATED_KEYS is specified, Statement.getGeneratedKeys should return an empty
ResultSet, not null 
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-4031
>                 URL: https://issues.apache.org/jira/browse/DERBY-4031
>             Project: Derby
>          Issue Type: Bug
>          Components: JDBC
>    Affects Versions: 10.3.3.0, 10.4.2.0, 10.5.1.1
>            Reporter: Kathey Marsden
>
> Currently Derby returns null from Statement.getGeneratedKeys() if  the statement is prepared
or executed with Statement.NO_GENERATED_KEYS. The javadoc says:
> If this Statement object did not generate any keys, an empty ResultSet object is returned.
> so we should return an empty ResultSet for this case.  It is not entirely clear what
the structure of the ResultSet and ResultSetMetaData should be.  I tend to think the following:
> getConcurrency() - inherit from the parent statement
> getStatement() - null
> ResultSetMetaData
> getColumnCount - 0
> an alternative would be to have the ResultSetMetaData match the signature of Identity_Val_local()
but I think to return 0 columns makes more sense.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message