db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Closed: (DERBY-4311) BaseJDBCTestCase.assertErrorCode() never fails
Date Fri, 17 Jul 2009 14:17:15 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Knut Anders Hatlen closed DERBY-4311.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 10.6.0.0

Committed revision 795092.

> BaseJDBCTestCase.assertErrorCode() never fails
> ----------------------------------------------
>
>                 Key: DERBY-4311
>                 URL: https://issues.apache.org/jira/browse/DERBY-4311
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.6.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>             Fix For: 10.6.0.0
>
>         Attachments: assertErrorCode.diff
>
>
> BaseJDBCTestCase.assertErrorCode() doesn't throw an exception if the error code does
not match the expected code.
>     public static void assertErrorCode(String message, int expected, SQLException exception)
{
>        while (exception != null)
>        {
>            try {
>                assertEquals(message, expected,exception.getErrorCode());
>            } catch (AssertionFailedError e) {
>                // check and see if our error code is in a chained exception
>                exception = exception.getNextException();               
>            }
>        }
>     }
> If the error code doesn't match, assertEquals() will raise an error, but the exception
is caught and silently ignored.
> Since none of the tests uses assertErrorCode() I suggest we remove it. We can re-implement
one that works later if the need arises.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message