db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4317) convert columnDefaults.sql to JUNIT
Date Fri, 31 Jul 2009 21:14:14 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737712#action_12737712
] 

Bryan Pendleton commented on DERBY-4317:
----------------------------------------

Hi Eranda,

I think you are right, it may be better to keep most of the create table statements in the
test cases themselves,
since as you say the test is specifically testing the create table statement behavior.

We often use the decorateSQL pattern for tests which set up some sample data, and then test
the
behavior of the system with the sample data.

But here we are testing the create table statement itself, so this is a special case.

If you think that the test is more readable in its current state, then that is fine, I think
Mamta agreed
that this is an unusual situation and the decorateSQL technique may or may not be applicable:
https://issues.apache.org/jira/browse/DERBY-4317?focusedCommentId=12736829&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12736829


> convert columnDefaults.sql to JUNIT
> -----------------------------------
>
>                 Key: DERBY-4317
>                 URL: https://issues.apache.org/jira/browse/DERBY-4317
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Eranda Sooriyabandara
>            Assignee: Eranda Sooriyabandara
>            Priority: Minor
>         Attachments: ColumnDefaultsTest.diff, ColumnDefaultsTest.diff
>
>
> Conversion of the columnDefaults.sql to JUNIT

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message