db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4304) Network Server shutdown should handle exceptions and finish the server shutdown completely
Date Wed, 15 Jul 2009 14:08:14 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731449#action_12731449
] 

Knut Anders Hatlen commented on DERBY-4304:
-------------------------------------------

I noticed one small inconsistency: When iterating over sessionTable, the try block encloses
the entire loop, so an error in the middle of the table will prevent the rest of the sessions
from being closed. When iterating over threadList, the try block only encloses the body of
the loop, so we'll continue shutting down the rest of the threads in case of an error. It
would be good if the two loops were handled the same way.

Many of the lines use an odd mix of both tabs and spaces on the same line.

> Network Server shutdown should handle exceptions and finish the server shutdown completely
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-4304
>                 URL: https://issues.apache.org/jira/browse/DERBY-4304
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server
>    Affects Versions: 10.6.0.0
>            Reporter: Mamta A. Satoor
>            Assignee: Mamta A. Satoor
>         Attachments: DERBY4304_handleExceptions_patch1_diff.txt
>
>
> While working on DERBY-4053, found that an exception from Connection.close was not handled
properly by the server shutdown code which caused a new instance server startup to hang. Resolved
the problem with Connection close but in general, we should
> 1) Make sure an exception during shutdown processing does not prevent the remaining shutdown
tasks, like closing the server socket from occurring. 
> 2) Make sure any exceptions that occur in shutdown processing are reported to the console.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message