db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lily Wei (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-4314) With derby client setTransactionIsolation executes and commits even if isolation has not changed
Date Sun, 19 Jul 2009 18:51:14 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Lily Wei updated DERBY-4314:
----------------------------

    Attachment: DERBY-4314-2.diff

Thanks Kathey for looking at the patch. I change the check to be after trace. I will mark
DERBY-2064 as dup of this bug. I think getTransactionIsolation() will introduce server round
trip. I am not sure the performance impact will be huge. I add a check for supportsSessionDataCaching()
to prevent introduce server round trip if it is not cache. getTransactionIsolationX()is introduce
and setTransactionIsolation() and getTransactionIsolation() will be calling it. testSetTransactionIsolationCommitRollback
will be checking for assertEquals(1, count) thanks to Kathey's great points. I run suits.all
again and all the tests passed. I am running derbyall now.

> With derby client setTransactionIsolation executes and commits even if isolation has
not changed 
> -------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-4314
>                 URL: https://issues.apache.org/jira/browse/DERBY-4314
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC, Network Client
>    Affects Versions: 10.1.3.1, 10.2.2.0, 10.3.3.0, 10.4.2.0, 10.5.1.1, 10.6.0.0
>            Reporter: Kathey Marsden
>            Priority: Minor
>         Attachments: DERBY-4314-2.diff, DERBY-4314.diff
>
>
> With in EmbedConnection.setIsolation() we have a check to see if the isolation level
is the same and if so just return without doing a commit:
>   public void setTransactionIsolation(int level) throws SQLException {
> 		if (level == getTransactionIsolation())
> 			return;
> with org.apache.derby.client.am.Connection we have no such check. It would be good if
the client driver acted like embedded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message