db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mamta A. Satoor (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4304) Network Server shutdown should handle exceptions and finish the server shutdown completely
Date Tue, 21 Jul 2009 14:31:14 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733638#action_12733638
] 

Mamta A. Satoor commented on DERBY-4304:
----------------------------------------

with revision 796316, I have fixed the problem of stack trace printing. The commit comments
were as follows
**************
DERBY-4304
When running in insane mode, the stack trace of the exception was not getting printed in the
console log file logs/serverConsoleOutput.log The reason for this is that the code was
doing following
           consolePropertyMessage("DRDA_UnexpectedException.S",
               exception.getMessage());
           consoleExceptionPrintTrace(exception);
That is, the stack trace printing was happening after the call to consolePropertyMessage.
The call to consolePropertyMessage results into a call to consolePropertyMessageWork which
may throw an exception back depending on the type of the error it is handling. If this method
does throw an exception, then consoleExceptionPrintTrace does not get a chance to dump the
stack trace into the logs/serverConsoleOutput. (Probably in sane mode, there is some other
additional place where we do the stack trace printing and that is why we saw the stack trace
despite consolePropertyMessage throwing an exception.) To fix the problem, I have switched
the order of the 2 calls above and that makes sure that we do print the stack trace for debugging
purpose.
**************


> Network Server shutdown should handle exceptions and finish the server shutdown completely
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-4304
>                 URL: https://issues.apache.org/jira/browse/DERBY-4304
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server
>    Affects Versions: 10.6.0.0
>            Reporter: Mamta A. Satoor
>            Assignee: Mamta A. Satoor
>         Attachments: DERBY4304_handleExceptions_patch1_diff.txt
>
>
> While working on DERBY-4053, found that an exception from Connection.close was not handled
properly by the server shutdown code which caused a new instance server startup to hang. Resolved
the problem with Connection close but in general, we should
> 1) Make sure an exception during shutdown processing does not prevent the remaining shutdown
tasks, like closing the server socket from occurring. 
> 2) Make sure any exceptions that occur in shutdown processing are reported to the console.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message