Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 76483 invoked from network); 30 Jun 2009 23:51:01 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 30 Jun 2009 23:51:01 -0000 Received: (qmail 42119 invoked by uid 500); 30 Jun 2009 23:51:12 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 42092 invoked by uid 500); 30 Jun 2009 23:51:12 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 42084 invoked by uid 99); 30 Jun 2009 23:51:12 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Jun 2009 23:51:12 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Jun 2009 23:51:09 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id F1565234C004 for ; Tue, 30 Jun 2009 16:50:47 -0700 (PDT) Message-ID: <1619871504.1246405847973.JavaMail.jira@brutus> Date: Tue, 30 Jun 2009 16:50:47 -0700 (PDT) From: "Tiago R. Espinha (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Updated: (DERBY-3834) Convert derbynet/runtimeinfo to JUnit In-Reply-To: <2087271661.1218487364295.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tiago R. Espinha updated DERBY-3834: ------------------------------------ Attachment: DERBY-3834.patch Attaching a new patch to this issue. After having discussed this with Kathey on IRC, we agreed on an alternative solution for this issue. Instead of separating the locale test from the actual RuntimeInfo test, I created a LocaleTestSetup decorator that allows the test to run with different localizations. The solution I found to manage the expected outputs was to use an HashMaps inside HashMaps. This way we're able to select the set of expected outputs for a certain locale easily, and then it is also easy to pick the correct output message within the results for that locale. It might not be the best solution performance-wise, but this way it is rather easy to add new locales to be tested, should we want to. Still, some input and alternative ideas are appreciated. > Convert derbynet/runtimeinfo to JUnit > ------------------------------------- > > Key: DERBY-3834 > URL: https://issues.apache.org/jira/browse/DERBY-3834 > Project: Derby > Issue Type: Improvement > Components: Test > Affects Versions: 10.5.1.1 > Reporter: Erlend Birkenes > Assignee: Tiago R. Espinha > Priority: Minor > Attachments: DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.stat, Derby-3834_1.diff > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.