db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tiago R. Espinha (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-3834) Convert derbynet/runtimeinfo to JUnit
Date Mon, 29 Jun 2009 13:59:47 GMT

     [ https://issues.apache.org/jira/browse/DERBY-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tiago R. Espinha updated DERBY-3834:
------------------------------------

    Attachment: DERBY-3834.patch

Attaching a new patch file.

This patch removes the test from the exclude and the runall files and it also addresses the
locale issue. In the old test, it seems that the locale wasn't even being properly tested.
In this patch however, in the x_testRuntimeInfoLocale() fixture I changed the locale to German,
restarted the server and then the fixture is processed normally (accounting for German output).
Just before the fixture ends, I reset the locale back to what it was originally and once more
restart the server so that the last fixture is able to complete normally.

There's one detail I'd like to get some input on. I added a method to this test called waitForServerShutdown(),
which, as the name suggests, holds on the execution until the server shuts down. This has
the same purpose as NetworkServerTestSetup.waitForServerStart(); but in this case we also
want to wait for it to shutdown. Would it be acceptable to create the waitForServerShutdown()
method also in the NetworkServerTestSetup? It might be useful for other tests and it's pretty
standard, it just waits for the server to shutdown. Plus, if other tests require it in the
future, they won't have to re-implement it locally.

Finally, I also added the comment on the singleUseDatabase usage, like Kathey suggested.

> Convert derbynet/runtimeinfo to JUnit
> -------------------------------------
>
>                 Key: DERBY-3834
>                 URL: https://issues.apache.org/jira/browse/DERBY-3834
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.5.1.1
>            Reporter: Erlend Birkenes
>            Assignee: Tiago R. Espinha
>            Priority: Minor
>         Attachments: DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.patch, DERBY-3834.stat,
Derby-3834_1.diff
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message