db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4293) Mutable public static variables
Date Tue, 30 Jun 2009 11:26:47 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725580#action_12725580

Sebb commented on DERBY-4293:

Sorry, I've no idea of whether the Configuration variables are needed or not.

I just ran a PMD script that looks for mutable static variables and tried to make them final
where possible. Defensive coding.

> Mutable public static variables
> -------------------------------
>                 Key: DERBY-4293
>                 URL: https://issues.apache.org/jira/browse/DERBY-4293
>             Project: Derby
>          Issue Type: Improvement
>          Components: Build tools, Network Client, SQL, Store
>    Affects Versions:
>            Reporter: Sebb
>         Attachments: derbyfinal.patch, derbyfinal2.patch
> There are quite a few instances of public static fields which appear to be intended to
be constant, but which are not final.
> The code would be safer if all the constant fields were made final.
> Patch to follow for some of the problem fields.
> The following also ought to be fixed:
> org.apache.derby.iapi.services.property.PropertyUtil.servicePropertyList (e.g. use an
accessor to lookup the values)
> org.apache.derby.iapi.types.JSQLType.primitiveNames (ditto)

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message