db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4217) Make the default port for the suites.All run configurable with a system property.
Date Wed, 10 Jun 2009 18:12:07 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718156#action_12718156
] 

Kathey Marsden commented on DERBY-4217:
---------------------------------------

I looked a the patch DERBY-4217.dtp.patch and just have one comment:

BaseTestCase - execJavaCmd 
	     I don't really like so much adding the portIsSpecified parameter to execJavaCmd and
translating that into "-p <portNumber>" since it is supposed to be a generic java command
execution.  I think it would be better to just pass the -p and portnumber in the cmd[] array
or perhaps have a separate execNetworkServerControl method.



> Make the default port for the suites.All run configurable with a system property.
> ---------------------------------------------------------------------------------
>
>                 Key: DERBY-4217
>                 URL: https://issues.apache.org/jira/browse/DERBY-4217
>             Project: Derby
>          Issue Type: Sub-task
>    Affects Versions: 10.6.0.0
>            Reporter: Tiago R. Espinha
>            Assignee: Tiago R. Espinha
>         Attachments: DERBY-4217-dtp.patch, DERBY-4217-dtp.patch, DERBY-4217-dtp.patch,
DERBY-4217-dtp.patch, DERBY-4217-ij.patch, DERBY-4217-ij.patch, DERBY-4217-ij.patch, DERBY-4217-ij.patch,
DERBY-4217-ij.patch, DERBY-4217-ij.stat, DERBY-4217-ij.stat, DERBY-4217.patch, DERBY-4217.patch,
DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.stat, DERBY-4217.stat, ErrorLog_suitesAll_bound.tgz,
ReproNetworkServerControl.java
>
>
> The goal is to make the port used for suites.All configurable through a system property
passed on to the JVM.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message