db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4217) Make the default port for the suites.All run configurable with a system property.
Date Tue, 16 Jun 2009 17:21:07 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720248#action_12720248
] 

Kathey Marsden commented on DERBY-4217:
---------------------------------------

I looked at DERBY-4217dtap patch.  
I think there is a typo on line 1022
        this.alternativePort = copy.port;
should be 
        this.alternativePort = copy.alternativePort;

Regarding Bryan's comment on renaming the property. I think that would be fine or perhaps
just derby.tests.secondServerPort in case another tests wants to start a second server.  Either
way is fine.

But ...
Tiago and I talked on IRC about any potential conflict between this port and the ports used
in ServerPropertiesTest and he determined there would be none because they are run sequentially,
but it is a bit confusing and he had a suggestion for a cleaner implementation  which would
encapsulate all the alternative port  assignments in TestConfiguration.   I will let him summarize
that idea.




> Make the default port for the suites.All run configurable with a system property.
> ---------------------------------------------------------------------------------
>
>                 Key: DERBY-4217
>                 URL: https://issues.apache.org/jira/browse/DERBY-4217
>             Project: Derby
>          Issue Type: Sub-task
>    Affects Versions: 10.6.0.0
>            Reporter: Tiago R. Espinha
>            Assignee: Tiago R. Espinha
>         Attachments: DERBY-4217-dtap.patch, DERBY-4217-dtap.patch, DERBY-4217-dtp.patch,
DERBY-4217-dtp.patch, DERBY-4217-dtp.patch, DERBY-4217-dtp.patch, DERBY-4217-dtp.patch, DERBY-4217-ij.patch,
DERBY-4217-ij.patch, DERBY-4217-ij.patch, DERBY-4217-ij.patch, DERBY-4217-ij.patch, DERBY-4217-ij.stat,
DERBY-4217-ij.stat, DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.patch,
DERBY-4217.stat, DERBY-4217.stat, ErrorLog_suitesAll_bound.tgz, ReproNetworkServerControl.java
>
>
> The goal is to make the port used for suites.All configurable through a system property
passed on to the JVM.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message