db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tiago R. Espinha (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4184) Calling deleteRow() on a ResultSet that has been commited throws no error
Date Fri, 26 Jun 2009 20:21:49 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724696#action_12724696
] 

Tiago R. Espinha commented on DERBY-4184:
-----------------------------------------

Dag,

The original issue is with deleteRow() and not with the update. The problem is that when the
ResultSet is created with ResultSet.CONCUR_UPDATABLE and we try to *delete* a row, it appears
as if the delete succeeded (no exception is thrown) but in fact, nothing happens.

I'm looking at your patch and I see that you added the updateRow() method after the updateInt(),
but with my Repro, the test wouldn't even get that far. It would fail on line 70 (in my test).

I haven't run this repro lately though and perhaps this has been fixed in another issue? By
looking at your repro, I would think it failed too in the same line. Does the deleteRow()
method now throw an exception? Because otherwise it really should fail.

> Calling deleteRow() on a ResultSet that has been commited throws no error
> -------------------------------------------------------------------------
>
>                 Key: DERBY-4184
>                 URL: https://issues.apache.org/jira/browse/DERBY-4184
>             Project: Derby
>          Issue Type: Bug
>          Components: JDBC
>    Affects Versions: 10.6.0.0
>         Environment: Not relevant.
>            Reporter: Tiago R. Espinha
>            Priority: Minor
>         Attachments: ReproHoldCursorBug.java, ReproHoldCursorBug_OK.java
>
>
> This issue was originally found on DERBY-3839.
> The steps to get this error happening are as follows:
> 1) Set auto commit to false
> 2) Create a Statement with the following parameters:
> ResultSet.TYPE_SCROLL_INSENSITIVE, ResultSet.CONCUR_UPDATABLE and ResultSet.HOLD_CURSORS_OVER_COMMIT
> 3) Create a ResultSet by having a SELECT on an executeQuery() on a table with at least
one row.
> 4) Do a next(); on the ResultSet. Then commit() and try to deleteRow() on the ResultSet.
> According to holdCursorJDBC30.out, the deleteRow() should throw an 'Invalid cursor state
- no current row' but it doesn't, not when using Java code.
> The problem here is the ResultSet.CONCUR_UPDATABLE. By setting this property, the ResultSet
checks that the property is different from CONCUR_READ_ONLY and doesn't do a proper check
on checkForUpdatableResultSet(). Without this check, the deleteRow() executes successfully
BUT, the row does NOT get deleted.
> After talking about this with Kathey, we agreed that the exception should always happen.
If an exception isn't thrown and the row isn't deleted, then this is certainly misleading

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message