Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <800037539.1243277865629.JavaMail.jira@brutus>
Date: Mon, 25 May 2009 11:57:45 -0700 (PDT)
From: "Tiago R. Espinha (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Issue Comment Edited: (DERBY-4217) Make the default port for
 the suites.All run configurable with a system property.
In-Reply-To: <945410248.1241646090281.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DERBY-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712774#action_12712774 ] 

Tiago R. Espinha edited comment on DERBY-4217 at 5/25/09 11:56 AM:
-------------------------------------------------------------------

So to wrap it up in a nutshell. We need four ports as far as testing goes:
- derby.tests.port
- derby.tests.alternativePort
- derby.tests.replicationPort
- derby.tests.slavePort

And basically, if they aren't explicitly set, they can be defined with offsets based on a port. This port is 1527 unless otherwise overridden with the derby.tests.port property.

My idea is to add four (static) properties to TestConfiguration and force the decorators to use these properties [which are set to their default values or to the system properties if they are defined]. The point of having new properties is that I need a coherent way of fetching at least the main port from within other tests (like the ij test). I could just fetch the system property from within the other tests, but that doesn't seem a good programming practice at all.

      was (Author: espinha):
    So to wrap it up in a nutshell. We need four ports as far as testing goes:
- derby.tests.port
- derby.tests.alternativePort
- derby.tests.replicationPort
- derby.tests.slavePort

And basically, if they aren't explicitly set, they can be defined with offsets based on a port. This port is 1527 unless otherwise overridden with the derby.tests.port property.

My idea is to add four (static) properties to TestConfiguration and force the decorators to use these properties [which are set to their default values or to the system properties if they are defined]. The point of having new properties is that I need a coherent way of fetching at least the main port from within other tests (like the ij test). I could just fetch the property from within the other tests, but that doesn't seem a good programming practice at all.
  
> Make the default port for the suites.All run configurable with a system property.
> ---------------------------------------------------------------------------------
>
>                 Key: DERBY-4217
>                 URL: https://issues.apache.org/jira/browse/DERBY-4217
>             Project: Derby
>          Issue Type: Sub-task
>    Affects Versions: 10.6.0.0
>            Reporter: Tiago R. Espinha
>            Assignee: Tiago R. Espinha
>         Attachments: DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.stat, DERBY-4217.stat, ReproNetworkServerControl.java
>
>
> The goal is to make the port used for suites.All configurable through a system property passed on to the JVM.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.