From derby-dev-return-68580-apmail-db-derby-dev-archive=db.apache.org@db.apache.org Mon May 04 19:56:54 2009 Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 41689 invoked from network); 4 May 2009 19:56:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 4 May 2009 19:56:54 -0000 Received: (qmail 940 invoked by uid 500); 4 May 2009 19:56:54 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 886 invoked by uid 500); 4 May 2009 19:56:54 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 878 invoked by uid 99); 4 May 2009 19:56:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 May 2009 19:56:54 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 May 2009 19:56:52 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 27FCF234C003 for ; Mon, 4 May 2009 12:56:31 -0700 (PDT) Message-ID: <1848374691.1241466991131.JavaMail.jira@brutus> Date: Mon, 4 May 2009 12:56:31 -0700 (PDT) From: "Kathey Marsden (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Commented: (DERBY-3839) Convert "org.apache.derbyTesting.functionTests.tests.store.holdCursorJDBC30.sql" to junit. In-Reply-To: <2099681545.1218704144316.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-3839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705714#action_12705714 ] Kathey Marsden commented on DERBY-3839: --------------------------------------- Thanks Tiago for the patch. The test looks good, but we need to add the new test to store._Suite and remove the old test from derbynetmats.runall, storemore.runall and j9derbynetmats.runall. It might be cleanest to change the result set to be updatable as Dag suggests to get consistent client/embedded behavior and add a comment as to why this was done. > Convert "org.apache.derbyTesting.functionTests.tests.store.holdCursorJDBC30.sql" to junit. > ------------------------------------------------------------------------------------------- > > Key: DERBY-3839 > URL: https://issues.apache.org/jira/browse/DERBY-3839 > Project: Derby > Issue Type: Test > Components: Test > Reporter: Junjie Peng > Assignee: Tiago R. Espinha > Attachments: derby-3839-1.patch, derby-3839-1.stat, derby-3839.patch, derby-3839.patch, ReproHoldCursorBug.java, ReproHoldCursorBug.java, ReproHoldCursorBug.java > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.