db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-4187) Convert altertable.sql to JUnit
Date Mon, 04 May 2009 02:23:30 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Bryan Pendleton updated DERBY-4187:

    Attachment: AlterTableTest.java

Hi Eranda, thank for the updated AlterTableTest patch.

It seems that you are making very good progress.

I took your patch, and I made some changes to AlterTableTest.java,
and am attaching the version that I modified.

There are going to be a number of small aspects to consider.

Perhaps you can have a look at the AlterTableTest.java that I attached,
and diff it against yours, and see some of the changes that I made?

Some changes are because the automatic conversion program does
not get everything exactly right, and so we have to fix up the test program
slightly, such as when it gets the column names in the result set wrong.

Some other changes are because there are behavior differences between
embedded mode and client/server mode, and we'll have to study those
each in detail to understand them (such as the case where the ALTER TABLE
is supposed to behave differently when a cursor is open on the table).

Please have a look at the revised AlterTableTest that I attached and let me
know your reaction to the changes that I made. 

If the changes make sense to you, perhaps you can continue in this mode,
making additional changes as necessary similar to the ones I made.

> Convert altertable.sql to JUnit
> -------------------------------
>                 Key: DERBY-4187
>                 URL: https://issues.apache.org/jira/browse/DERBY-4187
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions:
>            Reporter: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For:
>         Attachments: AlterTable.diff, AlterTable.java, AlterTableTest.diff, AlterTableTest.diff,
AlterTableTest.diff, AlterTableTest.java
>   Original Estimate: 486.08h
>  Remaining Estimate: 486.08h
> Converting altertable.sql harness test to JUnit

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message