db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4217) Make the default port for the suites.All run configurable with a system property.
Date Fri, 15 May 2009 18:37:45 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709928#action_12709928

Kathey Marsden commented on DERBY-4217:

hmmm, on looking at this more closely, I don't think that changing DEFAULT_PORT is the way
to go as that should just be a constant representing what the default is if it is not overriden

Perhaps  port should just be  initialized  to either DEFAULT_PORT or the system property as
appropriate  in the no argument constructor.    I don't quite get why it is being set to -1
 and  the hostName to null instead being set to the defaults.

If you do it this way, the tests would call TestConffiguration.getCurrent() .getPort() or
TestConfiguration.getCurrent().newNetworkServerControl() which would rely upon the port and
hostName fields in the current TestConfiguration object.  I really don't think they should
be referencing the static value directly.  I think maybe it should be private even.

> Make the default port for the suites.All run configurable with a system property.
> ---------------------------------------------------------------------------------
>                 Key: DERBY-4217
>                 URL: https://issues.apache.org/jira/browse/DERBY-4217
>             Project: Derby
>          Issue Type: Sub-task
>    Affects Versions:
>            Reporter: Tiago R. Espinha
>            Assignee: Tiago R. Espinha
>         Attachments: DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.patch,
DERBY-4217.stat, DERBY-4217.stat, ReproNetworkServerControl.java
> The goal is to make the port used for suites.All configurable through a system property
passed on to the JVM.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message