db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tiago R. Espinha (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4217) Make the default port for the suites.All run configurable with a system property.
Date Fri, 15 May 2009 17:27:45 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709915#action_12709915
] 

Tiago R. Espinha commented on DERBY-4217:
-----------------------------------------

Hello Kathey.

I'm not sure I get the point of having such a method on the TestConfiguration. I believe that
having a way of overriding the derby.tests.port property might put in jeopardy the whole purpose
of this issue. This issue was originally created as part of DERBY-4090, and if there is the
possibility of overriding this property, then concurrent testing on the same machine might
have unexpected results (i.e. two tests, one from JUnit and another one from Canon, trying
to bind on the 1527 port).

As to the second point, I agree that it would be more correct to have a getPort() on the TestConfiguration
and actually such method does exist already. However, this method returns the property port
that is stored within TestConfiguration. In some cases, this port is specified through methods
such as existingServerSuite(Class testClass, boolean cleanDB, String hostName, int portNumber)
or clientExistingServerSuite(...).

I'm just not sure if it's wise to mess with the port property that already exists in TestConfiguration.

By tapping into the DEFAULT_PORT property, I think I managed to make the change more transparent
for the majority of the tests, although it still remains to be seen how we'd handle tests
that specify their own port, as Dag pointed out on DERBY-4090.

On that last point, I agree. It was my bad #:)

> Make the default port for the suites.All run configurable with a system property.
> ---------------------------------------------------------------------------------
>
>                 Key: DERBY-4217
>                 URL: https://issues.apache.org/jira/browse/DERBY-4217
>             Project: Derby
>          Issue Type: Sub-task
>    Affects Versions: 10.6.0.0
>            Reporter: Tiago R. Espinha
>            Assignee: Tiago R. Espinha
>         Attachments: DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.patch,
DERBY-4217.stat, DERBY-4217.stat, ReproNetworkServerControl.java
>
>
> The goal is to make the port used for suites.All configurable through a system property
passed on to the JVM.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message