db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4217) Make the default port for the suites.All run configurable with a system property.
Date Thu, 14 May 2009 23:10:47 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709623#action_12709623
] 

Kathey Marsden commented on DERBY-4217:
---------------------------------------

Hi Tiago.  Thank you for the patch. Just a few comments.


For NetworkServerControlApi changes, I think it would be worthwile to have a TestConfiguration.newNetworkServerControl()
method that uses the default host and port in case we want to fix up the tests to allow remote
testing.

In general, outside of TestConfiguration, I think a TestConfiguration.getPort() method would
be better than referring to DEFUALT_PORT directly.

I think it would be good if the runScript method that doesn't take the loadSystemProperties
parameter just called the new one with loadSystemProperties set to false instead of having
duplicate code.  Then you can also remove the old getUtilMain method from Main.java 



> Make the default port for the suites.All run configurable with a system property.
> ---------------------------------------------------------------------------------
>
>                 Key: DERBY-4217
>                 URL: https://issues.apache.org/jira/browse/DERBY-4217
>             Project: Derby
>          Issue Type: Sub-task
>    Affects Versions: 10.6.0.0
>            Reporter: Tiago R. Espinha
>            Assignee: Tiago R. Espinha
>         Attachments: DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.patch, DERBY-4217.patch,
DERBY-4217.stat, DERBY-4217.stat, ReproNetworkServerControl.java
>
>
> The goal is to make the port used for suites.All configurable through a system property
passed on to the JVM.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message