db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-4204) Runtime statistics not collected on re-execution of statement
Date Tue, 12 May 2009 11:59:46 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Knut Anders Hatlen updated DERBY-4204:

    Attachment: d4204.diff

First I thought we should reset the NoRowsResultSetImpl's dumpedStats flag, either in close()
or when reopening the result set. But when I looked closer, I noticed that dumpedStats is
only ever used in close(), and close() is short-circuited before we dump the stats if close()
is called again before the result set is reopened. So I think we could just as well remove
the flag and rely on the isOpen flag to protect against dumping the same stats multiple times.

The attached patch (d4204.diff) removes the dumpedStats flag and makes close() always dump
the stats if the result set is open. It also adds regression tests for this bug.

All the regression tests passed.

> Runtime statistics not collected on re-execution of statement
> -------------------------------------------------------------
>                 Key: DERBY-4204
>                 URL: https://issues.apache.org/jira/browse/DERBY-4204
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions:
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d4204.diff, repro.sql, test.diff
> Runtime statistics are only collected the first time an insert/update/delete statement
is executed. The behaviour changed between Derby and Derby, so this was
likely introduced by DERBY-827.
> Reported on derby-dev:
> http://mail-archives.apache.org/mod_mbox/db-derby-dev/200904.mbox/%3c8a0216de0904291334j4bc715c3s6d46fb65e5953659@mail.gmail.com%3e

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message