Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <2030445535.1238800214763.JavaMail.jira@brutus>
Date: Fri, 3 Apr 2009 16:10:14 -0700 (PDT)
From: "Mike Matrigali (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Updated: (DERBY-1062) Change the internal implemetation of
 SYSCS_INPLACE_COMPRESS_TABLE to share existing alter table
In-Reply-To: <412439192.1141079095096.JavaMail.jira@ajax.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DERBY-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Matrigali updated DERBY-1062:
----------------------------------


I agree, document it as it is.  I would think best to change the text of the error message to be less specific about the caller now that the code is shared, while still explicitly documented the actual problem.  Something like "Operation failed because table/view xxx does not exist".  It will be a little less informative to alter table users, but they should already know what statement they are executing.  If the error is in the derby.log then the statement is actually printed.

I would rather not see more code in the alter table code trying to figure out who called it.

> Change the internal implemetation of SYSCS_INPLACE_COMPRESS_TABLE to share existing alter table
> -----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1062
>                 URL: https://issues.apache.org/jira/browse/DERBY-1062
>             Project: Derby
>          Issue Type: Improvement
>          Components: Newcomer, SQL, Store
>    Affects Versions: 10.1.3.1
>            Reporter: Mike Matrigali
>            Assignee: Mamta A. Satoor
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: d1062-escape.diff, d1062-escape.diff
>
>
>  Change the internal implemetation of SYSCS_INPLACE_COMPRESS_TABLE to share existing alter table
> code. One suggested approach is to use the same mechanism as SYSCS_COMPRESS_TABLE. Such
> an implementation would involve:
> o change the parser for alter table to accecpt some internal only syntax for SYSCS_INPLACE_COMPRESS_TABLE
> o change the alter table constant action to get the required information for inplace compress
> o move most of the inplace compress driving code to a routine in alter table execution, following the same
>      coding pattern as existing alter table compress.
> I believe doing this will have multiple benefits:
> 1) shares existing alter table code, so things like error checking, security management, ... is all done by one piece of code
> 2) by sharing the code I believe the following outstanding JIRA issues will be addressed: DERBY-719, DERBY-720 -
> 3) future changes addressing ddl like grant/revoke will automatically work.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.