db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tiago R. Espinha (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-3839) Convert "org.apache.derbyTesting.functionTests.tests.store.holdCursorJDBC30.sql" to junit.
Date Wed, 22 Apr 2009 21:40:47 GMT

     [ https://issues.apache.org/jira/browse/DERBY-3839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tiago R. Espinha updated DERBY-3839:
------------------------------------

    Attachment: derby-3839.patch

I went through Junjie's patch line-by-line and here's what I changed:

- Added the 'for update' clause where it was missing, to mimic the original test.
- Added the setAutoCommit(false) on the setUp() method.
- Set the bulkFetch to 1 where it was missing, as per the original test.
- Removed assertTrue(true) from the exceptions as I believe this is a waste of space and resources.
- Checked the order of all the close() and commit() calls, so that it also mimics the original
test (there were a few wrong ones as Mamta said).
- Made the asserts so that we check the actual data in the tables rather than just the row
number.

Now, the problem is that when I run the test, I systematically get errors like "Table/View
'FOO' already exists in Schema 'APP'.".

Ideally we'd create the tables on the decorator so that they'd be self-managed, but that isn't
optimal as each test has its own requirement as far as tables go. Some require the tables
to be empty, some require some records in it, and it is often the case that the tables are
simply different.

With this said, I kept Junjie's approach of creating and dropping the tables on each fixture.
I must be doing something wrong though, as I keep hitting that error.

Just to cover all possibilities, I added a commit() call after the dropTable is called but
still no luck. I still get the same errors and I must be missing something.

If anyone has any ideas, I'd appreciate it.

> Convert "org.apache.derbyTesting.functionTests.tests.store.holdCursorJDBC30.sql" to junit.

> -------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3839
>                 URL: https://issues.apache.org/jira/browse/DERBY-3839
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>            Reporter: Junjie Peng
>            Assignee: Tiago R. Espinha
>         Attachments: derby-3839-1.patch, derby-3839-1.stat, derby-3839.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message