db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John H. Embretsen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4134) Remove a rebundent use of derby.jar in DERBY tutorial, and add an easier way to start Network Server
Date Wed, 01 Apr 2009 06:53:14 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694409#action_12694409
] 

John H. Embretsen commented on DERBY-4134:
------------------------------------------

I had a quick look at the patch (in source code format, so I did not apply the patch and check
the rendered results in a web browser).
Generally it looks good, though I'd like to see some minor changes:

+<p class="code-block">Windows:
+C:\Apache\db-derby-10.4.1.3-bin\bin&gt; java -jar derbyrun.jar server start

I do not think that command will work if your current working directory is the bin directory,
as shown. When using the java -jar invocation method you need to reference the jar file directly.
Something like this would work:

+<p class="code-block">Windows:
+C:\Apache\db-derby-10.4.1.3-bin&gt; java -jar lib\derbyrun.jar server start

or:

+<p class="code-block">Windows:
+C:\Apache\db-derby-10.4.1.3-bin\lib&gt; java -jar derbyrun.jar server start


Less importantly, as you are removing the entry for derby.jar in this context, maybe it would
be good to let users know that they still need to have the jar file in the same location as
before. This is just a suggestion, e.g. like this:

 <span class="codefrag">derbynet.jar</span>: contains the code for
-    the Derby Network Server
+    the Derby Network Server and a reference to the engine jar file (derby.jar)


Finally, I suggest changing the header "An easier way" to "An easier way: derbyrun.jar" or
something like that, which I think would be more informative. Perhaps others have a better
suggestion?



> Remove a rebundent use of derby.jar in DERBY tutorial, and add an easier way to start
Network Server
> ----------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-4134
>                 URL: https://issues.apache.org/jira/browse/DERBY-4134
>             Project: Derby
>          Issue Type: Improvement
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Yun Lee
>            Assignee: Yun Lee
>         Attachments: DERBY-4134-1.diff
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message