db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3002) Add support for GROUP BY ROLLUP
Date Mon, 06 Apr 2009 12:55:13 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696066#action_12696066
] 

Knut Anders Hatlen commented on DERBY-3002:
-------------------------------------------

This issue has had what looks like a fairly complete patch for quite some time. Should we
try to get it committed?

I haven't studied the details of the patch, but the general approach looks fine to me. I think
this is a very useful feature even if the performance is suboptimal.

My only comments after reading the patch, are

1) If I read http://wiki.apache.org/db-derby/OLAPRollupLists correctly, the set of expected
rows returned by the test case lacks one row: {null,null,null,"12"}

2) The patch appears to have been created with a text editor whose tab size is 8, so the new
space-indented lines are too far to the right

> Add support for GROUP BY ROLLUP
> -------------------------------
>
>                 Key: DERBY-3002
>                 URL: https://issues.apache.org/jira/browse/DERBY-3002
>             Project: Derby
>          Issue Type: Sub-task
>          Components: SQL
>    Affects Versions: 10.4.1.3
>            Reporter: Bryan Pendleton
>            Assignee: Bryan Pendleton
>            Priority: Minor
>         Attachments: IncludesASimpleTest.diff, prototypeChangeNoTests.diff
>
>
> Provide an implementation of the ROLLUP form of multi-dimensional grouping according
to the SQL standard.
> See http://wiki.apache.org/db-derby/OLAPRollupLists for some more detailed information
about this aspect of the SQL standard.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message