db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4187) Convert altertable.sql to JUnit
Date Sun, 26 Apr 2009 11:46:32 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702875#action_12702875
] 

Knut Anders Hatlen commented on DERBY-4187:
-------------------------------------------

Hi Eranda,

I haven't performed a complete review of your patch, but I have some high-level comments:

- The new file needs an Apache license header. http://www.apache.org/legal/src-headers.html

- The AlterTable class is in package stack, whereas it should be in package org.apache.derbyTesting.functionTests.tests.lang

- By convention, we normally add a Test suffix to the class names when we write JUnit tests,
so the class name of the new test would be AlterTableTest

- There are some parts of the test that haven't been converted, marked with [**:: UNCONVERTED
::**]. I think we should try to find a way to convert those parts before we disable the old
test

- the old test used to set some properties, see derbyTesting/functionTests/tests/lang/altertable_derby.properties

- altertable.sql is removed, but the old regression test suite still attempts to run it, so
it should be removed from derbyTesting/functionTests/suites/derbylang.runall too. Also, the
files functionTests/master/altertable.out and functionTests/tests/lang/altertable_derby.properties
should be removed when the test is removed

> Convert altertable.sql to JUnit
> -------------------------------
>
>                 Key: DERBY-4187
>                 URL: https://issues.apache.org/jira/browse/DERBY-4187
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.4.2.1
>            Reporter: Eranda Sooriyabandara
>            Priority: Minor
>             Fix For: 10.5.1.2
>
>         Attachments: AlterTable.diff, AlterTable.java
>
>   Original Estimate: 486.08h
>  Remaining Estimate: 486.08h
>
> Converting altertable.sql harness test to JUnit

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message