db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] Closed: (DERBY-1371) Remove test harness special handling for handle varying client column widths
Date Wed, 29 Apr 2009 00:42:30 GMT

     [ https://issues.apache.org/jira/browse/DERBY-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kathey Marsden closed DERBY-1371.
---------------------------------

    Resolution: Won't Fix

This is being resolved (ever slow slowly) by converting the tests to JUnit. No point in putting
effort into changing the old harness now.


> Remove test harness special handling  for handle varying client  column widths
> ------------------------------------------------------------------------------
>
>                 Key: DERBY-1371
>                 URL: https://issues.apache.org/jira/browse/DERBY-1371
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.1.3.1
>            Reporter: Kathey Marsden
>            Priority: Minor
>
> The test harness has code in FileCompare to normailze the column widths for test output
to accommodate different  column widths in embedded and client.  I think the columnwidths
should be the same so this is not needed for client.
> It would be good to remove this logic for client (but keep it for JCC) to make sure that
 client and embedded do indeed match in this regard.  I think the harness change itself  entails
changing the section below in FileCompare to use isJCC Connection(framework) instead of  isClientConnection:
 What differences will be found I don't know.
> 		
> 		if (NetServer.isClientConnection(framework))
> 		{
>             try
>             {
> 		        Sed sed = new Sed();
> 				File JCCOutFile = new File(outDir, testBase + ".tmpmstr");
> 		        sed.execJCC(is, JCCOutFile);
> 				is = new FileInputStream(JCCOutFile);
> 		    }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message