db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mamta A. Satoor (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-1062) Change the internal implemetation of SYSCS_INPLACE_COMPRESS_TABLE to share existing alter table
Date Fri, 03 Apr 2009 21:21:12 GMT

    [ https://issues.apache.org/jira/browse/DERBY-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695588#action_12695588
] 

Mamta A. Satoor commented on DERBY-1062:
----------------------------------------

Kathey, I agree with what you are saying. It is confusing to get an error message for alter
table when the user never sent ALTER TABLE... sql I was thinking I will go ahead and create
the release note for the current behavior and we can discuss what the error message should
look like so it is not confusing. With the old implementation, we could be very specific and
say Table does not exist but now that we try to use ALTER TABLE code internally, we are falling
into the mechanism of ALTER TABLE implementation where we don't distinguish internal calls
to ALTER TABLE and throw generic error message which includes ALTER TABLE text in it.

So, is it ok if I provide a release note for what the current behavior is in 10.5 or should
we make code changes so the error message is not misleading? I am open to any of the two.

> Change the internal implemetation of SYSCS_INPLACE_COMPRESS_TABLE to share existing alter
table
> -----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1062
>                 URL: https://issues.apache.org/jira/browse/DERBY-1062
>             Project: Derby
>          Issue Type: Improvement
>          Components: Newcomer, SQL, Store
>    Affects Versions: 10.1.3.1
>            Reporter: Mike Matrigali
>            Assignee: Mamta A. Satoor
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: d1062-escape.diff, d1062-escape.diff
>
>
>  Change the internal implemetation of SYSCS_INPLACE_COMPRESS_TABLE to share existing
alter table
> code. One suggested approach is to use the same mechanism as SYSCS_COMPRESS_TABLE. Such
> an implementation would involve:
> o change the parser for alter table to accecpt some internal only syntax for SYSCS_INPLACE_COMPRESS_TABLE
> o change the alter table constant action to get the required information for inplace
compress
> o move most of the inplace compress driving code to a routine in alter table execution,
following the same
>      coding pattern as existing alter table compress.
> I believe doing this will have multiple benefits:
> 1) shares existing alter table code, so things like error checking, security management,
... is all done by one piece of code
> 2) by sharing the code I believe the following outstanding JIRA issues will be addressed:
DERBY-719, DERBY-720 -
> 3) future changes addressing ddl like grant/revoke will automatically work.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message