Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 16898 invoked from network); 22 Mar 2009 22:18:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 22 Mar 2009 22:18:36 -0000 Received: (qmail 7792 invoked by uid 500); 22 Mar 2009 22:18:36 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 7713 invoked by uid 500); 22 Mar 2009 22:18:36 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 7705 invoked by uid 99); 22 Mar 2009 22:18:36 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Mar 2009 22:18:36 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of m.v.lunteren@gmail.com designates 209.85.146.182 as permitted sender) Received: from [209.85.146.182] (HELO wa-out-1112.google.com) (209.85.146.182) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Mar 2009 22:18:28 +0000 Received: by wa-out-1112.google.com with SMTP id l24so1006492waf.23 for ; Sun, 22 Mar 2009 15:18:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=NGf7K+faXGISkILWBVhR0Xyj6cXFwd9o7Z78pnb6PL4=; b=JFYt4xkDJ8SAQkCxKozVhC3HzIK3XAOTLzyTj1Ml4oqvzewmGO6o2JkbcrDumdEY+/ /YAOdSda1GrZP6BKRuiQPTUwH1YLY9M08RpdZqyLbykQSjpV2hPRC2TzYhtLADSMgAiT h9R/AEuFv/bHwN1uFUX9VnEI3ve9cIAUzl3FY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=NWxleghSmSFd78gTQXD4nS7U1WGoOlrJ5hK1rsdYNLzltQFSTgf3tUR2VTl0DonZXE XKmZxuglDj6e+e66NcXjbQBXTPe8kxuWGuN5QEqjAhRDt4RiqnU3zW8kIpLXCFmLAllm Vv90gcs/+3oaOhb5uMmOo7aLnJbOj9bP7I/ag= MIME-Version: 1.0 Received: by 10.114.210.2 with SMTP id i2mr4328968wag.44.1237760284673; Sun, 22 Mar 2009 15:18:04 -0700 (PDT) In-Reply-To: References: Date: Sun, 22 Mar 2009 15:18:04 -0700 Message-ID: Subject: Re: Tests missing on holdCursorExternalSortJDBC30.sql ? From: Myrna van Lunteren To: derby-dev@db.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On Sun, Mar 22, 2009 at 2:53 PM, Tiago Espinha wrote: > Hey guys, > I am working on DERBY-4090 and I started with the > holdCursorExternalSortJDBC30.sql . The thing is that on the file's overvi= ew, > 10 tests are reported as follows: > -- overview: > -- =A0 =A0TEST =A00: test hold cursor with external sort (order by). > -- =A0 =A0TEST =A01: basic heap =A0scan tests (multiple rows) > -- =A0 =A0TEST =A02: basic btree scan tests (zero rows/update nonkey fiel= d) > -- =A0 =A0TEST =A03: basic btree scan tests (multiple rows/update nonkey = field) > -- =A0 =A0TEST =A04: basic btree scan tests (zero rows/read only/no group= fetch) > -- =A0 =A0TEST =A05: basic btree scan tests (multiple rows/read only/no g= roup > fetch) > -- =A0 =A0TEST =A06: basic tests for cursors with order by > -- =A0 =A0TEST =A07: test of hold cursor code in > DistinctScalarAggregateResultSet.java > -- =A0 =A0TEST =A08: test of hold cursor code in GroupedAggregateResultSe= t.java > -- =A0 =A0TEST =A09: test scan positioned on a row which has been purged. > -- =A0 =A0TEST 10: test scan positioned on a page which has been purged > However, only two actual tests exist in that file. Is this normal or am I > missing something? Why would the remaining tests have been removed? > Tiago Hi Tiago, Converting this test is actually DERBY-3842 - currently owned by Junjie, but I think you can just assign yourself and link it to DERBY-4090. Junjie made a patch but there were some comments that never got addressed. But to get to the point you were asking - looks to me like the top of comments at the top of the test are somewhat bogus - looks like someone might have done a cut-and-paste from holdCursorJDBC30.sql and never adjusted the comments. HTH. Myrna