Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <1389172488.1236696051215.JavaMail.jira@brutus>
Date: Tue, 10 Mar 2009 07:40:51 -0700 (PDT)
From: "Knut Anders Hatlen (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-4087) Clean up debug printing of the
 abstract syntax trees after parsing, binding and optimization
In-Reply-To: <1750223180.1236622070834.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DERBY-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680480#action_12680480 ] 

Knut Anders Hatlen commented on DERBY-4087:
-------------------------------------------

I think truncating already seen subtrees is a good idea as it (a) reduces the size of the printed tree and (b) makes it easier to see that two trees are actually the same one. Doing it always is fine with me. As you mentioned, the current output is often inconsistent, and I find it unlikely that anyone rely on the exact output, so I don't see a need for a knob. It is debug output, after all. If someone does need a stable, parsable output, DERBY-791 sounds like a better fit.

> Clean up debug printing of the abstract syntax trees after parsing, binding and optimization 
> ---------------------------------------------------------------------------------------------
>
>                 Key: DERBY-4087
>                 URL: https://issues.apache.org/jira/browse/DERBY-4087
>             Project: Derby
>          Issue Type: Improvement
>          Components: Miscellaneous, SQL
>            Reporter: Dag H. Wanvik
>            Priority: Trivial
>
> Currently, the printing is often inconsistent:
> - some subtrees not printed
> - wrong indentation due to missing newlines, or lacking level increments
> - redundant printing of subtrees (AST is really a DAG, would be nice to print only once and then refer back to show aliasing)
> - some items printed twice due to inconsistent usage of pattern

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.