db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3842) Convert "org.apache.derbyTesting.functionTests.tests.store.holdCursorExternalSortJDBC30.sql" to junit.
Date Mon, 30 Mar 2009 14:52:50 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693792#action_12693792
] 

Bryan Pendleton commented on DERBY-3842:
----------------------------------------

I think it's OK to have a test which only runs in SANE mode. That's better than not
having a test at all, in my opinion. And I think that using these special internal
properties to force the test through the code path that we want it to take is fine,
because it is after all a test, and is intending to test that particular behavior.

So I think you should leave your test as is, using the special properties, but
adjust it so that the test checks to see whether this is a SANE or INSANE build,
and skips the test in the INSANE configuration, and you should submit your patch.

It will be good to have a test which we know is reliably forcing an external sort,
because we need to have coverage of the external sort behaviors and this is one
way to do that.


> Convert "org.apache.derbyTesting.functionTests.tests.store.holdCursorExternalSortJDBC30.sql"
to junit.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3842
>                 URL: https://issues.apache.org/jira/browse/DERBY-3842
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>            Reporter: Junjie Peng
>            Assignee: Tiago R. Espinha
>         Attachments: derby-3842-1.patch, derby-3842-1.stat, derby-3842-tiago.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message