db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mamta A. Satoor (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2487) Enhance Derby with EXPLAIN Functionality
Date Tue, 03 Mar 2009 21:26:56 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678453#action_12678453
] 

Mamta A. Satoor commented on DERBY-2487:
----------------------------------------

Bryan, great job in bringing the patch back upto date with the trunk and figuring out this
large patch from the original submitter. I just have couple comments
1)In RealAnyResultSetStatistics.java, RealDistinctScalarAggregateStatistics.java and RealWindowResultSetStatistics.java,
do we need to check if childResultSetStatistics is not empty before we set number of children
to 1. If yes, then we should also check childResultSetStatistics is not empty 
before calling childResultSetStatistics.accept(visitor); This is what we are doing in the
rest of the patch.
2)In RealCurrentOfStatistics.java, should we be calling visitor.visit(this); after setting
the number of children to 0?
3)In XPLAINFactory.java, while trying to determine the appropriate XPLAINVisitor, if we get
an exception, then we are printing the stack trace. That at some point should be fixed. Should
the fix be that if we run into exception, just use the default visitor? 
java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINFactory.java	
4)I noticed in couple places in XPLAINSystemTableVisitor.java where we do printStackTrace
on the exception. The error handling is probably already on your to-do list but I thought
I would point it out.

> Enhance Derby with EXPLAIN Functionality
> ----------------------------------------
>
>                 Key: DERBY-2487
>                 URL: https://issues.apache.org/jira/browse/DERBY-2487
>             Project: Derby
>          Issue Type: New Feature
>          Components: SQL
>    Affects Versions: 10.2.2.0
>            Reporter: Felix Beyer
>            Assignee: Bryan Pendleton
>            Priority: Minor
>         Attachments: Derby physical XPLAIN schema.png, incorporateTrunkChanges.diff,
removeSourceDepth.diff, RSProtocolNew.pdf, rts.xls, small logical xplain schema.pdf, startRegressionTest.diff,
startRegressionTest.diff, startUpgradeTests.diff, updateRegressionTests.diff, updateRegressionTests.diff,
usage.txt, xplain_patch_v1.txt, xplainClasses.pdf
>
>
> This enhancement extends Derby with EXPLAIN functions. Users want to have more feedback
than they`re getting with the current RuntimeStatistics facility. This extension is based
on the RuntimeStatistics/ResultSetStatistics functions / classes. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message