db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2031) Convert derbynet/testProtocol.java to JUnit
Date Mon, 23 Mar 2009 08:58:50 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688247#action_12688247
] 

Kristian Waagan commented on DERBY-2031:
----------------------------------------

I think we are still running two versions of the test; one with an adapter in the drda package
(to avoid making a set of methods public), and the new JUnit test.
The reason why the latter hasn't replaced the old test, is the packaging problem. Due to this,
the test is only run when running against classes, and it isn't run as part of suites.All.
Changes done to the protocol test file will affect both versions of the test.

One way forward could be to write a smaller adapter and have the new JUnit test use it to
be able to run the test against the JARs (I haven't investigated this approach).

> Convert derbynet/testProtocol.java to JUnit
> -------------------------------------------
>
>                 Key: DERBY-2031
>                 URL: https://issues.apache.org/jira/browse/DERBY-2031
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server, Test
>    Affects Versions: 10.3.1.4
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: d2031.diff, d2031.stat, derby-2031-1a-grammar_enum.diff, derby-2031-1a-grammar_enum.stat,
derby-2031-2a-test.diff, derby-2031-3a-enable_test.diff, derby-2031-3a-enable_test.stat, derby-2031-3b-enable_test.diff,
derby-2031-4a-close_streams.diff
>
>
> testProtocol.java executes DRDA commands from a file written in a special-purpose language.
The statements are very much like assertions, so it should be fairly easy to convert the test
to JUnit.
> Suggested approach: Change the interpreter (TestProto.java) so that is uses Assert.fail()
instead of System.err.println() and System.exit(), and BaseTestCase.println() instead of System.out.println().
It should also use TestConfiguration to get the host name and port number.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message