Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 65843 invoked from network); 10 Feb 2009 17:27:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 10 Feb 2009 17:27:38 -0000 Received: (qmail 52951 invoked by uid 500); 10 Feb 2009 17:27:37 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 52929 invoked by uid 500); 10 Feb 2009 17:27:37 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 52920 invoked by uid 99); 10 Feb 2009 17:27:37 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Feb 2009 09:27:37 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Feb 2009 17:27:37 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id C49B3234C4B5 for ; Tue, 10 Feb 2009 09:27:16 -0800 (PST) Message-ID: <263003810.1234286836804.JavaMail.jira@brutus> Date: Tue, 10 Feb 2009 09:27:16 -0800 (PST) From: "Rick Hillegas (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Commented: (DERBY-2201) Calling functions that return Blob/Clob does not work. In-Reply-To: <896851.1167309621015.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-2201?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1267= 2327#action_12672327 ]=20 Rick Hillegas commented on DERBY-2201: -------------------------------------- Thanks for the feedback, Kristian and Knut. Here are some responses. I will= post a revised patch which addresses your comments. > Should the position arguments in the code below be 1L instead of 0L?=20 Thanks for catching that. > I see that SQLBinary.estimateMemoryUsage() was updated. Should SQLChar.es= timateMemoryUsage() be updated too?=20 Thanks for noticing that asymmetry. After mulling this over further, I came= to the conclusion that if the data is really in a user Clob or Blob, then = the space is already allocated. It would be wrong to increase the estimated= memory by the length of the Lob because we intend to use the streaming api= if we can. So I have removed the changes to SQLBinary.estimateMemoryUsage(= ). > Where will the new constructors and the new setValue(Clob) be used? Is it= only in the case of functions, and for SQLClob?=20 Thanks for raising this question. It caused me to go through the code and f= ind that, due to some short-circuiting in the pinball machine, we were not = taking advantage of the streaming apis. It has taken me a while to get back= to you because this is tricky code to debug. I had to decompile the genera= ted code and prune it back so that I could see the forest instead of the tr= ees--a painstaking process. These methods will be invoked in SQL statements which invoke Lob-returning = functions. I don't know of other cases but I can't promise that they don't = exist. Today, those other cases would raise the compiler errors seen in thi= s bug. Here, for instance, is a case in which the compiler will generate code whic= h stuffs a user Clob into a SQLVarchar. The final INSERT statement generate= s that code: create function "clob_Clob_String" ( =09a_0 varchar( 10 ) ) returns clob language java parameter style java no sql external name 'org.apache.derbyTesting.functionTests.tests.lang.AnsiSignatu= res.clob_Clob_String' ; create table t2( a varchar( 32000 ) ); insert into t2( a ) values( cast( "clob_Clob_String"( 'abc' ) as varchar( 3= 2000)) ); > Calling functions that return Blob/Clob does not work. > ------------------------------------------------------ > > Key: DERBY-2201 > URL: https://issues.apache.org/jira/browse/DERBY-2201 > Project: Derby > Issue Type: Bug > Components: SQL > Affects Versions: 10.3.1.4 > Environment: Derby, head of trunk. Sun JVM 5. Solaris 10 (x86). > Reporter: =C3=98ystein Gr=C3=B8vlen > Priority: Minor > Attachments: ClobFunction.java, derby-2201-02-aa-wrapUserLob.diff= , derby-2201-aa-01-crudeDog.diff, getClobDataValue.diff > > > Calling functions that return Blob/Clob results in NoSuchMethodException = (See stackTrace below). It fails because DataValueFactory.getClobDataValue= (Clob, StringDataValue) does not exist. However, getClobDataValue(String,= StringDataValue) exists. I will attach program to repro this. > java.lang.NoSuchMethodException: org.apache.derby.iapi.types.DataValueFac= tory.getClobDataValue(java.sql.Clob, org.apache.derby.iapi.types.StringData= Value) at java.lang.Class.getDeclaredMethod(Class.java:1909) > at org.apache.derby.impl.services.bytecode.d_BCValidate.checkMeth= od(d_BCValidate.java:133) > at org.apache.derby.impl.services.bytecode.BCMethod.callMethod(BC= Method.java:745) > at org.apache.derby.impl.sql.compile.BaseTypeCompiler.generateDat= aValue(BaseTypeCompiler.java:135) > at org.apache.derby.impl.sql.compile.ExpressionClassBuilder.gener= ateDataValue(ExpressionClassBuilder.java:918) > at org.apache.derby.impl.sql.compile.JavaToSQLValueNode.generateE= xpression(JavaToSQLValueNode.java:179) > at org.apache.derby.impl.sql.compile.CastNode.generateExpression(= CastNode.java:884) > at org.apache.derby.impl.sql.compile.SQLToJavaValueNode.generateS= QLValue(SQLToJavaValueNode.java:361) > at org.apache.derby.impl.sql.compile.SQLToJavaValueNode.generateE= xpression(SQLToJavaValueNode.java:341) > at org.apache.derby.impl.sql.compile.JavaToSQLValueNode.generateE= xpression(JavaToSQLValueNode.java:176) > at org.apache.derby.impl.sql.compile.ResultColumn.generateExpress= ion(ResultColumn.java:884) > at org.apache.derby.impl.sql.compile.ResultColumnList.generateCor= e(ResultColumnList.java:1097) > at org.apache.derby.impl.sql.compile.ProjectRestrictNode.generate= Minion(ProjectRestrictNode.java:1516) > at org.apache.derby.impl.sql.compile.ProjectRestrictNode.generate= (ProjectRestrictNode.java:1303) > at org.apache.derby.impl.sql.compile.ScrollInsensitiveResultSetNo= de.generate(ScrollInsensitiveResultSetNode.java:110) > at org.apache.derby.impl.sql.compile.CursorNode.generate(CursorNo= de.java:565) > at org.apache.derby.impl.sql.compile.StatementNode.generate(State= mentNode.java:333) > at org.apache.derby.impl.sql.GenericStatement.prepMinion(GenericS= tatement.java:447) > at org.apache.derby.impl.sql.GenericStatement.prepare(GenericStat= ement.java:88) > at org.apache.derby.impl.sql.conn.GenericLanguageConnectionContex= t.prepareInternalStatement(GenericLanguageConnectionContext.java:741) > at org.apache.derby.impl.jdbc.EmbedPreparedStatement.(Embed= PreparedStatement.java:129) > at org.apache.derby.impl.jdbc.EmbedPreparedStatement20.(Emb= edPreparedStatement20.java:83) > at org.apache.derby.impl.jdbc.EmbedPreparedStatement30.(Emb= edPreparedStatement30.java:63) > at org.apache.derby.jdbc.Driver30.newEmbedPreparedStatement(Drive= r30.java:93) > at org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(Em= bedConnection.java:742) > at org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(Em= bedConnection.java:586) > at lobtests.ClobFunction.main(ClobFunction.java:87) > Invalid method org.apache.derby.iapi.types.DataValueFactory >> org.apache= .derby.iapi.types.StringDataValue getClobDataValue(java.sql.Clob, org.apach= e.derby.iapi.types.StringDataValue) because java.lang.NoSuchMethodException= : org.apache.derby.iapi.types.DataValueFactory.getClobDataValue(java.sql.Cl= ob, org.apache.derby.iapi.types.StringDataValue) > java.sql.SQLException: Java exception: 'ASSERT FAILED Invalid method org.= apache.derby.iapi.types.DataValueFactory >> org.apache.derby.iapi.types.Str= ingDataValue getClobDataValue(java.sql.Clob, org.apache.derby.iapi.types.St= ringDataValue) because java.lang.NoSuchMethodException: org.apache.derby.ia= pi.types.DataValueFactory.getClobDataValue(java.sql.Clob, org.apache.derby.= iapi.types.StringDataValue): org.apache.derby.shared.common.sanity.AssertFa= ilure'. > org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED Invali= d method org.apache.derby.iapi.types.DataValueFactory >> org.apache.derby.i= api.types.StringDataValue getClobDataValue(java.sql.Clob, org.apache.derby.= iapi.types.StringDataValue) because java.lang.NoSuchMethodException: org.ap= ache.derby.iapi.types.DataValueFactory.getClobDataValue(java.sql.Clob, org.= apache.derby.iapi.types.StringDataValue) > at org.apache.derby.shared.common.sanity.SanityManager.THROWASSER= T(SanityManager.java:149) > at org.apache.derby.impl.services.bytecode.d_BCValidate.checkMeth= od(d_BCValidate.java:192) > at org.apache.derby.impl.services.bytecode.BCMethod.callMethod(BC= Method.java:745) > at org.apache.derby.impl.sql.compile.BaseTypeCompiler.generateDat= aValue(BaseTypeCompiler.java:135) > at org.apache.derby.impl.sql.compile.ExpressionClassBuilder.gener= ateDataValue(ExpressionClassBuilder.java:918) > at org.apache.derby.impl.sql.compile.JavaToSQLValueNode.generateE= xpression(JavaToSQLValueNode.java:179) > at org.apache.derby.impl.sql.compile.CastNode.generateExpression(= CastNode.java:884) > at org.apache.derby.impl.sql.compile.SQLToJavaValueNode.generateS= QLValue(SQLToJavaValueNode.java:361) > at org.apache.derby.impl.sql.compile.SQLToJavaValueNode.generateE= xpression(SQLToJavaValueNode.java:341) > at org.apache.derby.impl.sql.compile.JavaToSQLValueNode.generateE= xpression(JavaToSQLValueNode.java:176) > at org.apache.derby.impl.sql.compile.ResultColumn.generateExpress= ion(ResultColumn.java:884) > at org.apache.derby.impl.sql.compile.ResultColumnList.generateCor= e(ResultColumnList.java:1097) > at org.apache.derby.impl.sql.compile.ProjectRestrictNode.generate= Minion(ProjectRestrictNode.java:1516) > at org.apache.derby.impl.sql.compile.ProjectRestrictNode.generate= (ProjectRestrictNode.java:1303) > at org.apache.derby.impl.sql.compile.ScrollInsensitiveResultSetNo= de.generate(ScrollInsensitiveResultSetNode.java:110) > at org.apache.derby.impl.sql.compile.CursorNode.generate(CursorNo= de.java:565) > at org.apache.derby.impl.sql.compile.StatementNode.generate(State= mentNode.java:333) > at org.apache.derby.impl.sql.GenericStatement.prepMinion(GenericS= tatement.java:447) > at org.apache.derby.impl.sql.GenericStatement.prepare(GenericStat= ement.java:88) > at org.apache.derby.impl.sql.conn.GenericLanguageConnectionContex= t.prepareInternalStatement(GenericLanguageConnectionContext.java:741) > at org.apache.derby.impl.jdbc.EmbedPreparedStatement.(Embed= PreparedStatement.java:129) > at org.apache.derby.impl.jdbc.EmbedPreparedStatement20.(Emb= edPreparedStatement20.java:83) > at org.apache.derby.impl.jdbc.EmbedPreparedStatement30.(Emb= edPreparedStatement30.java:63) > at org.apache.derby.jdbc.Driver30.newEmbedPreparedStatement(Drive= r30.java:93) > at org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(Em= bedConnection.java:742) > at org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(Em= bedConnection.java:586) > at lobtests.ClobFunction.main(ClobFunction.java:87) --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.