[ https://issues.apache.org/jira/browse/DERBY-4042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669395#action_12669395 ] 

Bryan Pendleton commented on DERBY-4042:
----------------------------------------

The patch looks great, Knut. Thank goodness for IdUtil and StringUtil, they
are very useful. I had a little bit of struggle with the test, because I could see
where you added a test for quotes in schema name / table name (the IdUtil case),
but I couldn't see where you added a test for quotes in the file name (the StringUtil case).

Did I simply overlook that test?


> org.apache.derby.impl.load.Import needs to escape single quotes
> ---------------------------------------------------------------
>
>                 Key: DERBY-4042
>                 URL: https://issues.apache.org/jira/browse/DERBY-4042
>             Project: Derby
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 10.4.2.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>         Attachments: d4042-1.diff
>
>
> The code that builds the SQL statement that invokes the Import VTI doesn't properly escape single quotes. This causes problems for users, see: http://mail-archives.apache.org/mod_mbox/db-derby-user/200901.mbox/%3c21754463.post@talk.nabble.com%3e
> Import.performImport() is the method that needs to be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.