db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4042) org.apache.derby.impl.load.Import needs to escape single quotes
Date Sun, 01 Feb 2009 20:17:59 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669435#action_12669435
] 

Knut Anders Hatlen commented on DERBY-4042:
-------------------------------------------

Thanks for looking at the patch, Bryan!

There is only one added test case (testQuotesInArguments) and it actually does test quotes
in the file name, although somewhat indirectly. The helper method doExport() exports a table
to a file whose name is tableName + ".dat", and doImportAndVerify() imports a file with the
same name. So since the table name contains both a single quote and a double quote, the name
of the exported file should contain those characters too. It's probably worth a comment in
the test case to make it clearer.

> org.apache.derby.impl.load.Import needs to escape single quotes
> ---------------------------------------------------------------
>
>                 Key: DERBY-4042
>                 URL: https://issues.apache.org/jira/browse/DERBY-4042
>             Project: Derby
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 10.4.2.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>         Attachments: d4042-1.diff
>
>
> The code that builds the SQL statement that invokes the Import VTI doesn't properly escape
single quotes. This causes problems for users, see: http://mail-archives.apache.org/mod_mbox/db-derby-user/200901.mbox/%3c21754463.post@talk.nabble.com%3e
> Import.performImport() is the method that needs to be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message